prevent multiple identical compilations via watch startTime #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellscape
requested review from
sokra,
TheLarkInn,
joshwiens and
evenstensberg
2 tasks
|
It's been some weeks since this was opened and webpack/watchpack/issues/25 is still an ongoing issue with no resolution. This has been merged as a stop-gap until watchpack is updated to handle the scenario. Once that issue is resolved, this change will be reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
An inconvenience/bug fix and introduction of a new option.
Did you add tests for your changes?
n/a
Summary
This mimics the fix found in ff0000-ad-tech/wp-plugin-watch-offset which was the result of a long-standing bug in
watchpackin webpack/watchpack/issues/25. It resolves the endless - or random multiple - compile issue by advancing the time for watching and stats startTime. This is introduced through thewatchOffsetoption, which can be set to0to disable prevention and restore original behavior.Does this PR introduce a breaking change?
I do not believe so. It's unlikely.
Other information